feat: add DSA fields (dsa_beneficiary/dsa_payor) and bid_amount to create_adset - #10
Open
jesperholstjh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_adsetcurrently cannot create ad sets in two common situations:dsa_beneficiary(and acceptsdsa_payor) on ad sets delivering to the EU. Without them the API rejects creation with code 100, subcode 3858081 ("Specify the person or organisation being promoted"). This currently makescreate_adsetunusable for EU advertisers.bid_strategy: LOWEST_COST_WITH_BID_CAPorCOST_CAPrequiresbid_amount, which exists onupdate_adsetbut not oncreate_adset, so a capped ad set cannot be created in one call.This PR adds all three as optional params, forwarded to the API only when provided. No breaking changes.
Tested against the live Marketing API (v26.0, Danish ad account): ad set with DSA fields and bid cap created successfully; existing calls without the new fields behave as before.