Skip to content

Use MediaEmbed for video filter #158

Description

@dereuromark

The Video standalone filter is nice for starters.
But the issue is that you need to also maintain those video links/URLs/code all the time.
It could be beneficial to let a dedicated library take care of that
E.g. https://github.com/dereuromark/media-embed

To have BC and the choice we could add an optional
MediaEmbedVideoFilter which only adds the dependency as require-dev for testing
If you want to use you add the real dependency, otherwise no harm.

The working code can be seen here:
https://github.com/dereuromark/cakephp-markup/blob/master/src/Bbcode/Decoda/VideoFilter.php

What do you think?
Worth porting into, or should this be kept outside as own package shipping?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions