fix: resolve 7 GitHub issues (catalog resolution, file ignoring, CLI, RN, Next.js, offline, monorepo) by aidenybai · Pull Request #108 · millionco/react-doctor

aidenybai · 2026-03-23T03:22:43Z

Summary

Fixes 7 open GitHub issues across CLI usability, dependency detection, linting accuracy, and monorepo support.

Issues Fixed

#86 — File ignore patterns don't work with absolute paths

filterIgnoredDiagnostics now accepts rootDirectory and converts absolute diagnostic file paths to relative paths before matching against glob patterns. Previously, patterns like /resources/js/components/ui/** never matched because diagnostic paths included the full disk path.

#101, #105, #87 — pnpm/Bun catalog version resolution

Adds support for resolving catalog: and catalog:name version references from:

pnpm default catalogs defined in pnpm-workspace.yaml
pnpm named catalogs (e.g., catalog:react_v19_current)
Bun workspace catalogs (workspaces.catalog in package.json)
Catalog resolution from monorepo root when scanning a sub-package

#106 — Full scan in automated environments

When --yes or CI environment is detected, resolveDiffMode now defaults to full scan instead of diff-only scan. Users can still explicitly request diff mode with --diff. This allows agents and CI to reliably get a complete project scan.

#100 — False positive raw text in custom components

Components ending with Title, Label, Heading, Caption, or Subtitle are now treated as text-handling components in the rn-no-raw-text rule. This prevents false positives for components like Stack.Screen.Title and NativeTabs.Trigger.Label.

#83 — Misleading nextjs-no-client-side-redirect message

The diagnostic message now distinguishes between router.push(), router.replace(), window.location, and location.href instead of using the generic "Client-side redirect" label.

#89 — Offline score message

Updated OFFLINE_MESSAGE from "could not calculate score" to "Score calculated locally (offline mode)" since the score IS computed locally via calculateScoreLocally when --offline is used.

#73 — Monorepo root not listed as scannable project

listWorkspacePackages now includes the root directory in the project list when it has React dependencies, alongside its workspace packages.

Testing

All 139 tests pass (7 new tests added)
pnpm test ✅
pnpm lint ✅
pnpm typecheck ✅
pnpm format ✅

vercel · 2026-03-23T03:22:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
react-doctor-website	Ready	Preview, Comment	Apr 6, 2026 11:23pm

gerardosabetta · 2026-03-24T23:10:12Z

hey aiden, I'm so waiting for catalog version resolution to use the github action in our CI, any ETAs on when you're releasing this one? no rush, just curious

swijckmans · 2026-04-06T20:59:06Z

Hey Aiden,

I will bribe you with a Wooly Pig if this gets merged :)

filterIgnoredDiagnostics now accepts rootDirectory and converts absolute diagnostic file paths to relative paths before matching against glob patterns. This fixes the issue where ignore.files patterns like '/resources/js/components/ui/**' would never match because diagnostic paths included the full disk path. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

…, #105, #87) Adds support for: - pnpm default catalogs defined in pnpm-workspace.yaml - pnpm named catalogs (catalog:name syntax, e.g. catalog:react_v19_current) - Bun workspace catalogs (workspaces.catalog in package.json) - Catalog resolution from monorepo root when scanning a sub-package Includes test fixtures and tests for all three catalog formats. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

When --yes or CI environment is detected, resolveDiffMode now defaults to full scan instead of diff-only scan. Users can still explicitly request diff mode with --diff. This allows agents and CI to reliably get a complete project scan with 'npx react-doctor . --yes'. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

…ves (#100) Components ending with Title, Label, Heading, Caption, or Subtitle are now treated as text-handling components in the rn-no-raw-text rule. This prevents false positives for components like Stack.Screen.Title, NativeTabs.Trigger.Label, and other UI library components that correctly handle text rendering internally. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

… detected (#83) The diagnostic message now distinguishes between router.push(), router.replace(), window.location, and location.href assignments, making it clear what the rule actually found instead of using the generic 'Client-side redirect' label. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

…ly (#89) The OFFLINE_MESSAGE previously said 'could not calculate score' but the score IS computed locally via calculateScoreLocally when --offline is used. Updated to 'Score calculated locally (offline mode).'. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

listWorkspacePackages now includes the root directory in the project list when it has React dependencies, alongside its workspace packages. This fixes the issue where the root folder of a monorepo that is itself a React project was not listed for scanning. Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1ea9414. Configure here.}

cursor · 2026-04-06T23:30:06Z

packages/react-doctor/src/utils/discover-project.ts

+        const rootPackageJson = readPackageJson(monorepoPackageJsonPath);
+        reactVersion = resolveCatalogVersion(rootPackageJson, "react", monorepoRoot);
+      }
+    }


Named catalog reference lost during monorepo root resolution

Medium Severity

When a sub-package uses a named catalog reference like catalog:react_v19, resolveCatalogVersion correctly extracts the catalog name from the sub-package's dependencies on line 257. However, the pnpm-workspace.yaml isn't in the sub-package directory, so resolution fails. In the fallback on line 556, resolveCatalogVersion is called with the root's packageJson, which doesn't list react in its dependencies — so catalogName becomes null. resolveCatalogVersionFromCollection then iterates all named catalogs in arbitrary insertion order, potentially returning the wrong version when multiple named catalogs define the same package at different versions.

Additional Locations (1)

packages/react-doctor/src/utils/discover-project.ts#L254-L257

^{Reviewed by Cursor Bugbot for commit 1ea9414. Configure here.}

cursor · 2026-04-06T23:30:06Z

packages/react-doctor/src/utils/discover-project.ts

+    }
+
+    if (currentSection === "named-catalog" && indentLevel > 0) {
+      if (indentLevel <= 2 && trimmed.endsWith(":") && !trimmed.includes(" ")) {


Hard-coded indent breaks multi-catalog YAML parsing

Low Severity

The indentLevel <= 2 check in parsePnpmWorkspaceCatalogs hard-codes 2-space indentation for detecting sibling named catalog headers. With 4-space (or any >2) YAML indentation, the second and subsequent catalog names under catalogs: won't be recognized as new catalog sections — they'll be treated as key-value entries with empty values and silently skipped, causing their contents to be lost or misattributed to the previous catalog.

^{Reviewed by Cursor Bugbot for commit 1ea9414. Configure here.}

looskie · 2026-04-07T06:37:49Z

Akshay090 mentioned this pull request Mar 25, 2026

Issue with ignoring files or folders #86

Closed

cursoragent and others added 8 commits April 6, 2026 23:20

style: apply oxfmt formatting

bc5c668

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

cursor bot force-pushed the cursor/github-issues-resolution-e644 branch from 1d22551 to bc5c668 Compare April 6, 2026 23:21

vercel bot deployed to Preview April 6, 2026 23:22 View deployment

chore: upgrade @changesets/cli to ^2.30.0

1ea9414

Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

vercel bot deployed to Preview April 6, 2026 23:23 View deployment

aidenybai marked this pull request as ready for review April 6, 2026 23:24

aidenybai merged commit 1aef45a into main Apr 6, 2026
4 checks passed

cursor bot reviewed Apr 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve 7 GitHub issues (catalog resolution, file ignoring, CLI, RN, Next.js, offline, monorepo)#108

fix: resolve 7 GitHub issues (catalog resolution, file ignoring, CLI, RN, Next.js, offline, monorepo)#108
aidenybai merged 9 commits intomainfrom
cursor/github-issues-resolution-e644

aidenybai commented Mar 23, 2026

Uh oh!

vercel bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

gerardosabetta commented Mar 24, 2026

Uh oh!

swijckmans commented Apr 6, 2026

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Apr 6, 2026

Uh oh!

cursor bot Apr 6, 2026

Uh oh!

looskie commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

aidenybai commented Mar 23, 2026

Summary

Issues Fixed

#86 — File ignore patterns don't work with absolute paths

#101, #105, #87 — pnpm/Bun catalog version resolution

#106 — Full scan in automated environments

#100 — False positive raw text in custom components

#83 — Misleading nextjs-no-client-side-redirect message

#89 — Offline score message

#73 — Monorepo root not listed as scannable project

Testing

Uh oh!

vercel bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gerardosabetta commented Mar 24, 2026

Uh oh!

swijckmans commented Apr 6, 2026

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Apr 6, 2026

Choose a reason for hiding this comment

Named catalog reference lost during monorepo root resolution

Uh oh!

cursor bot Apr 6, 2026

Choose a reason for hiding this comment

Hard-coded indent breaks multi-catalog YAML parsing

Uh oh!

looskie commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel bot commented Mar 23, 2026 •

edited

Loading