fix: request license information from GitLab API

[Anni0506]

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Testing

Summary

This PR fixes an issue where the gitlab/license entity property (RepoPropertyLicense) is always empty for GitLab repositories. The fetch logic in internal/providers/gitlab/repository_properties.go has been updated to correctly pass the ?license=true query parameter required by the GitLab API to include license details in the response.

Fixes #6589

Testing

This is a straightforward API query parameter addition. The underlying gitlab provider package logic handles the mapping once the license payload is retrieved via the modified URL path.

[CLAassistant]

All committers have signed the CLA.

[Anni0506]

I have read the CLA Document and I hereby sign the CLA

[intelligent-ears]

This PR doesn't add any tests verifying that the license field actually gets populated.There can be at least a unit test for gitlabProjectToProperties that confirms license is non-empty when the API response includes a license.

[intelligent-ears]

The ?license=true is appended before the error check — the code appends the query param before checking if url.JoinPath returned an error. If JoinPath fails, projectURLPath would be an empty string and the append would produce just ?license=true. The correct order is:

projectURLPath, err := url.JoinPath("projects", url.PathEscape(upstreamID))
if err != nil {
    return nil, fmt.Errorf("failed to join URL path for project using upstream ID: %w", err)
}
projectURLPath = projectURLPath + "?license=true"

[evankanderson]

This PR doesn't add any tests verifying that the license field actually gets populated.There can be at least a unit test for gitlabProjectToProperties that confirms license is non-empty when the API response includes a license.

In particular, we should probably update Test_gitlabClient_FetchAllProperties in properties_test.go to properly emulate the server behavior, and complain / fail the test if the query param is not present.

[coveralls]

Coverage is 60.935% — Anni0506:fix/gitlab-license-property into mindersec:main. No base build found for mindersec:main.

[evankanderson]

Thanks for adding the tests! The test implementation brought up a couple questions (this is the learning process, so it's totally normal to hit these sorts of things).

[evankanderson]

Why change this name to empty-string?

[evankanderson]

Will this comment make sense in 6 months?

[evankanderson]

What does this test cover that the other test doesn't?

In general, extra tests add maintenance burden when refactoring code. That burden pays off when the tests cover additional important code cases, but redundant tests add more maintenance cost without commensurate benefits.