Draft
Conversation
HJLebbink
force-pushed
the
update-build-workflows
branch
from
6375a79 to
9da8a4d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CI/CD setup by removing the tests/start-server.sh script and replacing it with two separate GitHub Actions workflow files: one for OSS MinIO testing and one for AIStor MinIO testing. The server startup logic is now inline in each workflow, allowing different server sources and credentials to be used for each variant.
Key Changes:
- Deleted the shared
tests/start-server.shscript - Created
ci-aistor.ymlworkflow for testing against AIStor MinIO server with license-based authentication - Updated
ci-oss.ymlworkflow to inline the server startup commands and use OSS MinIO server
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/start-server.sh | Removed shared server startup script to enable variant-specific server configurations |
| .github/workflows/ci-oss.yml | Renamed to "MinIO OSS Rust Library" and inlined OSS MinIO server startup in both test jobs |
| .github/workflows/ci-aistor.yml | New workflow for testing against AIStor MinIO with license credentials from GitHub secrets |
HJLebbink
force-pushed
the
update-build-workflows
branch
5 times, most recently
from
13c6abe to
e9bf5f1
Compare
HJLebbink
force-pushed
the
update-build-workflows
branch
from
e9bf5f1 to
4cb02ca
Compare
HJLebbink
force-pushed
the
update-build-workflows
branch
from
4cb02ca to
9d4f36d
Compare
HJLebbink
force-pushed
the
update-build-workflows
branch
from
9d4f36d to
ae0a6fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.