fmakv2 version added to fma_keys - #694
Open
campeasb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fma_keys: add support for v2 metadata (backward-compatible)
One-liner:
Extend the existing
fma_keysdataset to support the v2 metadata/index while keeping full backward compatibility with v1.Description
This PR extends the existing
fma_keysloader to handle a v2 metadata format and index.There is no new dataset module; changes are limited to
fma_keysinternals + its top-level docstring.What’s included
fma_keysto clearly document:Note: Figures above reflect the established FMA Keys dataset characteristics; docstring now explicitly mentions v1 and v2 formats and how they’re handled.
Changes (code)
mirdata/datasets/fma_keys.pyto parse v2 metadata/index.Tests & coverage
fma_keystests continue to pass locally with v1.Documentation
fma_keysupdated to:Dataset loader checklist (adapted)
scripts/…(no new dataset module added in this PR).fma_keys.mirdata/datasets/fma_keys.py(extended, not duplicated).tests/test_full_dataset.pyonfma_keys(local sanity; CI to validate).Notes
fma_keys(v1 + v2), not on introducing a separate dataset.please-do-not-editif undesired).