Remove chardet, pytest-pep8 from dependencies, update music21 and fix haydn_op20 loader - #706
Merged
magdalenafuentes merged 7 commits intoJul 14, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 97.12% 97.13% +0.01%
==========================================
Files 71 71
Lines 7824 7828 +4
==========================================
+ Hits 7599 7604 +5
+ Misses 225 224 -1 🚀 New features to boost your workflow:
|
magdalenafuentes
approved these changes
Jul 14, 2026
magdalenafuentes
merged commit Jul 14, 2026
0f16526
into
mir-dataset-loaders:master
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #703, Closes #704
Description
Currently CI was failing because of chardet and music21.
Recent updates in chardet changed its encoding prediction, causing unicode extraction test to fail.
Encoding issue was found from irmas and goodsounds datasets, however, those two datasets can be encoded well with UTF-8. Therefore, fallback to chardet prediction in
extractall_unicodeis unnecessary.Recent updates in music21 changed the API: score.flat() -> score.flatten(), which breaks the test.
++ 0629
pytest loads the pytest-pep8 automatically, which is no longer compatible with pytest 9, and it rejects its outdate
pytest_collect_file(path, parent)hook signature.This makes pytest fail before any tests run.
Mirdata already uses flake8 for style checks, and currently, test does not use pytest-pep8. So pytest-pep8 is no longer needed.
Changes
extractall_unicode++0629
pytest-pep8from pyproject.toml and CI environment.