Conversation
Features - The descriptor interface is generalized to Bk - Add lammps support of Bk with multiple kernels, for both potential and variance - Add more unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request wraps up B1, B2, B3 descriptors into a Bk descriptor module. And should be merged after #12
is equivalent to current setting
The lammps files are changed correspondingly.
atom_indicestosparse_gp.py/update_dbandsparse_gp.cpp/add_training_structureto allow adding a subset of force labels, such that the Kuf matrix is smaller in the "f" dimensionNotes:
To add descriptors with higher body order, just need to add coefficients (l1, l2, l3 ...; m1, m2, m3, ...) to
coeffs.cppand add indices (n1 l1 m1, n2 l2 m2, ... nk lk mk) inindices.cpp.The original
b1/2/3.cppare kept for unit test, but we could delete them and might find better way of doing this.computecommand for variance to Bk descriptorsTodo
The lammps code can be further optimized: