Updated youtube-dl-exec, added deno js runtime#757
Open
DeltaCream wants to merge 1 commit intomiraclx:masterfrom
Open
Updated youtube-dl-exec, added deno js runtime#757DeltaCream wants to merge 1 commit intomiraclx:masterfrom
DeltaCream wants to merge 1 commit intomiraclx:masterfrom
Conversation
freyr-js has not been updated in a very long time. This is not intended as a comprehensive patch that will put it in an up-to-date, bleeding-edge state. Rather, this patch is intended to solve the key problems of using it to download songs from Spotify. Here are the following changes and why it was deliberately made that way: - kept @ffmpeg/core *strictly* at version 0.11.0. Based from npm's repository, this is the only version of @ffmpeg/core that is in minor version 0.11. That means that the update after it is minor version 0.12 onwards, which has breaking changes. - updated @ffmpeg/ffmpeg *strictly* at version 0.11.6. Same idea as the change above. - updated youtube-dl-exec to v3.0.28: this is the underlying library used to interface with yt-dlp, and as such, needs to be updated. - src/services/youtube.js updated to have the youtubedl object instantiation have the jsRuntime parameter (deno in this case). As for why it uses deno, it is the most recommended external JavaScript runtime for use with yt-dlp. The details for this is listed here: yt-dlp/yt-dlp#15012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freyr-js has not been updated in a very long time. This is not intended as a comprehensive patch that will put it in an up-to-date, bleeding-edge state. Rather, this patch is intended to solve the key problems of using it to download songs from Spotify. Here are the following changes and why it was deliberately made that way: