Extend proverbs datasets#13
Merged
Merged
Conversation
Adds 9 entries to proverbs_a (success/victory) and 19 entries to proverbs_b (perseverance/failure), covering the missing H-Z range from the wikiquote source. Also adds a Proverbs section to the README listing both complete sets, and excludes the local update_proverbs.R utility script from git and R package builds. Closes #1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Extends the package’s proverbs datasets and documents the resulting full proverb lists, aligning with Issue #1’s goal of completing the alphabetical coverage.
Changes:
- Update
proverbs_aandproverbs_bdatasets (stored as.RData) with additional proverb entries. - Add a new “## Proverbs” section to the README listing both datasets’ contents.
- Ignore a local utility script (
update_proverbs.R) in both git and R package builds.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
data/proverbs_a.RData |
Updated serialized dataset for success/victory proverbs. |
data/proverbs_b.RData |
Updated serialized dataset for perseverance/failure proverbs. |
README.md |
Adds a new section enumerating both proverb sets. |
.gitignore |
Ignores update_proverbs.R locally. |
.Rbuildignore |
Excludes update_proverbs.R from R package builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proverbs_a(success/victory context), covering the missing H–Z rangeproverbs_b(near-success/perseverance/failure context), covering the missing H–Z range## Proverbssection to the README with both complete sets listedupdate_proverbs.Rfrom git and R package builds via.gitignoreand.RbuildignoreCloses #1
Test plan
proverbs_ahas 22 entries and all are success/victory appropriateproverbs_bhas 46 entries and all are perseverance/failure appropriatepraise_pv()andencourage_pv()still work correctly🤖 Generated with Claude Code