Skip to content

add request timeout in report()#8

Open
delin wants to merge 1 commit intomirumee:masterfrom
delin:patch-1
Open

add request timeout in report()#8
delin wants to merge 1 commit intomirumee:masterfrom
delin:patch-1

Conversation

@delin
Copy link
Copy Markdown

@delin delin commented Nov 26, 2015

No description provided.

@codecov-io
Copy link
Copy Markdown

Current coverage is 100.00%

Branch #8 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.
Review entire Coverage Diff as of aeb4b9e

Powered by Codecov. Updated on successful CI builds.

@patrys
Copy link
Copy Markdown
Contributor

patrys commented Nov 27, 2015

What is the motivation? Would you like to shorten the time? 5 seconds does seem like a lot of time.

@delin
Copy link
Copy Markdown
Author

delin commented Nov 27, 2015

Yes. Because no asynchronous I would like to set a shorter timeout.

@delin
Copy link
Copy Markdown
Author

delin commented Nov 27, 2015

@patrys What do you think about that?

@patrys
Copy link
Copy Markdown
Contributor

patrys commented Nov 27, 2015

Sorry, I'm on vacation until Monday. I'd like to both shorten the default and allow custom timeouts.

@delin
Copy link
Copy Markdown
Author

delin commented Nov 27, 2015

Tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants