fix(extra): handle malformed JSON in structChat parsed response#230
Merged
Conversation
JSON.parse in convertToParsedChatCompletionResponse can throw a SyntaxError when the model returns malformed JSON (common when finish_reason is "length" and the output is truncated). Wrap the parse in try/catch and leave parsed as undefined so callers can detect the failure gracefully instead of crashing. Also adds unit tests covering malformed JSON, valid JSON failing schema validation, null content, empty choices, and undefined choices. Original work by @JacobiusMakes in #200.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON.parseinconvertToParsedChatCompletionResponse(src/extra/structChat.ts) throws aSyntaxErrorwhen the model returns malformed JSON, which happens regularly with structured outputs whenfinish_reasonislength(truncated mid-JSON). This crashes user code instead of returning a parsable response.Fix
Wrap the parse in try/catch. On failure, leave
parsedasundefinedso callers can detect the truncation gracefully.Also adds 5 unit tests covering malformed JSON, valid JSON failing schema validation, null content, empty choices, and undefined choices.
Credit
Original work by @JacobiusMakes in #200. Opening clean as part of the current release bundle.