Fix simulate function returning 0 for non-failing components#160
Open
Chessing234 wants to merge 1 commit intomitmath:Fall24from
Open
Fix simulate function returning 0 for non-failing components#160Chessing234 wants to merge 1 commit intomitmath:Fall24from
Chessing234 wants to merge 1 commit intomitmath:Fall24from
Conversation
Components that do not fail within the maximum number of time steps were incorrectly assigned a failure time of 0. Changed the sentinel value from 0 to max_steps so that non-failing components correctly report the maximum time step value. Also added max_steps as a configurable parameter (default 100). Fixes mitmath#154 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulatefunction insimulating_component_failure.jlwhere components that do not fail within the maximum number of time steps were incorrectly assigned a failure time of 0 instead of the maximum time step value.0tomax_stepsso non-failing components correctly reportmax_stepsas their failure time.max_stepsas a configurable parameter with a default of 100, maintaining backward compatibility.Fixes #154
Test plan
pvalues (e.g.,p = 0.01) and verify that no component shows a failure time of 0.p = 1.0to confirm all components still fail att = 1.🤖 Generated with Claude Code