Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WalkthroughThis pull request migrates the testing framework from Jest to Vitest. The migration includes removing the Jest configuration file, updating the test script in Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
vitest.config.ts (1)
6-10: Scope coverageincludeto source files only.The pattern
'**/*.[tj]s'will include all.tsand.jsfiles in the project (config files, scripts, etc.), which may inflate or skew coverage reports. Consider limiting to actual source code.♻️ Proposed fix
coverage: { provider: 'v8', - include: ['**/*.[tj]s'], + include: ['src/**/*.[tj]s'], exclude: ['node_modules', 'dist', 'vitest.config.ts', '.huskyrc.js'], },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@vitest.config.ts` around lines 6 - 10, The coverage include pattern in vitest.config.ts is too broad ('**/*.[tj]s') and should be restricted to your source files; update the coverage.include entry (coverage.include) to target only the src tree—e.g. use a pattern like 'src/**/*.{ts,tsx,js,jsx}' or 'src/**/*.[jt]s' so only application source files are measured and config/scripts are excluded.test/.eslintrc.json (1)
2-2: Consider adding Vitest-specific ESLint rules.The change from
mixmax/node/jesttomixmax/noderemoves Jest-specific linting. For feature parity (e.g., catching common Vitest test mistakes), you could addeslint-plugin-vitest. This is optional since the tests will still lint and run correctly without it.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/.eslintrc.json` at line 2, The ESLint config currently replaces "extends": "mixmax/node" which drops Jest rules; to add Vitest-specific linting install and enable eslint-plugin-vitest and update the config by adding the plugin and Vitest recommended rules (for example add "plugins": ["vitest"] and "extends": ["mixmax/node", "plugin:vitest/recommended"] and/or set "env": { "vitest/globals": true }) so tests get Vitest-aware rules while keeping "extends": "mixmax/node".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@test/.eslintrc.json`:
- Line 2: The ESLint config currently replaces "extends": "mixmax/node" which
drops Jest rules; to add Vitest-specific linting install and enable
eslint-plugin-vitest and update the config by adding the plugin and Vitest
recommended rules (for example add "plugins": ["vitest"] and "extends":
["mixmax/node", "plugin:vitest/recommended"] and/or set "env": {
"vitest/globals": true }) so tests get Vitest-aware rules while keeping
"extends": "mixmax/node".
In `@vitest.config.ts`:
- Around line 6-10: The coverage include pattern in vitest.config.ts is too
broad ('**/*.[tj]s') and should be restricted to your source files; update the
coverage.include entry (coverage.include) to target only the src tree—e.g. use a
pattern like 'src/**/*.{ts,tsx,js,jsx}' or 'src/**/*.[jt]s' so only application
source files are measured and config/scripts are excluded.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 251aff39-22fb-4e7e-836f-987e4c5a383d
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
jest.config.jspackage.jsonsrc/index.test.tstest/.eslintrc.jsonvitest.config.ts
💤 Files with no reviewable changes (1)
- jest.config.js
Summary
jest.*calls withvi.*equivalentsvitest.config.tsreplacingjest.configWhy
Company-wide standardization on Vitest for faster test execution and better DX (PLAT-350).
Test plan
Generated with Claude Code