feat: "Open config.toml" link in the settings panel footer - #39
Merged
Conversation
Windows Terminal's "Open JSON file" equivalent: a right-aligned accent link in the settings-panel footer bar opens config.toml with the OS default editor. - `platform::open_config_file` follows the `open_releases_url` pattern (open / xdg-open / `cmd /c start "" <path>` with CREATE_NO_WINDOW; the empty title argument keeps paths with spaces intact) and creates the file first when it does not exist yet. - Hit-test mirrors the footer geometry (`bottom_y` formula) and only the label region is clickable; the link colour goes through `ensure_readable` for the 4.5:1 contrast rule. - i18n: new `settings-open-config-file` key in all 8 locales. Note: the per-field "restore default" item originally planned for this phase moves into the P2 row-refactor, which introduces the per-row metadata it needs. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Coverage reportGenerated by |
…ANGELOG Unreleased sections
Coverage reportGenerated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P4 of the Windows-Terminal-like UX plan: a right-aligned accent link in the settings-panel footer bar opens
config.tomlwith the OS default editor — the equivalent of Windows Terminal's "Open JSON file" button, completing the GUI-settings + direct-file-edit two-tier flow.Changes
platform::open_config_file()follows the existingopen_releases_urlpattern (open/xdg-open/cmd /c start "" <path>withCREATE_NO_WINDOW); the emptystarttitle argument keeps paths with spaces intact. Creates the file (and parent dir) first when it does not exist.overlay/settings/mod.rs; the hit-test insettings_panel_hit.rsmirrors the samebottom_ygeometry. Link colour passesensure_readable(≥ 4.5:1 contrast).settings-open-config-filein all 8 locales.Scope note
The per-field "restore default" item originally sketched for this phase moves into the P2 settings-row refactor, which introduces the per-row metadata (default value + write-back target) it needs — wiring ~50 fields twice would be wasted work.
Test plan
cargo test -p nexterm-client-gpu -p nexterm-i18ngreen (714 + locale key-parity)cargo clippy --all-targets— no new warnings;cargo fmt --checkclean🤖 Generated with Claude Code