add accessor for estimated wait time#305
Conversation
|
I really need to move away from Azure and put the pipelines here, to help visibility. You'll need to at least address the lint failure: I'd also like to see a test for this change, would you be able to provide one? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 81 84 +3
Branches 10 10
=========================================
+ Hits 81 84 +3 ☔ View full report in Codecov by Sentry. |
|
|
I keep going back and forth on this, as I am not convinced that this information is all that useful. In addition, I think the naming here is wrong; the accessor returns the minimum wait time; if there are other tasks waiting the actual time will be longer, and calculating a better estimate is going to be quite a bit harder. What is your use case for this? There are some other nitpicks with some of the details of the PR but those can wait until we have figured out the fundamental question, that is, do we really need this. |



No description provided.