Allow localoptions.h to override individual ECC curves - #448
Merged
Conversation
Wrap DROPBEAR_ECC_256/384/521 in #ifndef guards so that localoptions.h can enable only specific curves rather than inheriting all of them from DROPBEAR_ECC. Without the guards, any per-curve override set before sysoptions.h is processed gets silently overwritten.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysoptions.hcurrently definesDROPBEAR_ECC_256/384/521unconditionally,so any per-curve setting in
localoptions.his silently overwritten.Wrapping them in
#ifndefguards lets users enable only specific curves(e.g. only P-256 on a constrained device) without needing to patch
sysoptions.hdirectly.