Avoid splitting long authorized_keys lines - #456
Merged
Merged
Conversation
When reading text files, a long line would finish parsing then the next iteration would continue with the tail of the line. Instead the line should be skipped entirely. Line lengths are now limited to 10000 characters, file parsing will stop if that limit is hit. Previously if external programs created authorized_keys entries from untrusted sources, that could have allowed bypass of public key restrictions or other confusion.
Otherwise a too-large authorized_keys file could take a very long time to iterate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading text files, a long line would finish parsing then the
next iteration would continue with the tail of the line.
Instead the line should be skipped entirely.
Line lengths are now limited to 10000 characters, file parsing will
stop if that limit is hit.
Previously if external programs created authorized_keys entries from
untrusted sources, that could have allowed bypass of public key
restrictions or other confusion.
Also limit number of authorized_keys lines to 300