Keep SetConnectAttrW buffers alive#1472
Open
bkline wants to merge 1 commit intomkleehammer:masterfrom
Open
Conversation
According to the ODBC specification, only a small handful of API functions are allowed to keep pointers for buffers of non-scalar values for use after the function has returned. The spec identifies each of those functions, and SetConnectAttrW is not one of them. However, Microsoft's ODBC Driver 18 for SQL Server does not comply with this restriction, and if we don't keep such buffers valid until after SQLDriverConnectW has returned, the application can crash. See microsoft/msphpsql#1594 for further details. Closes mkleehammer#1469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the ODBC specification, only a small handful of API functions are allowed to keep pointers for buffers of non-scalar values for use after the function has returned. The spec identifies each of those functions, and SetConnectAttrW is not one of them. However, Microsoft's ODBC Driver 18 for SQL Server does not comply with this restriction, and if we don't keep such buffers valid until after SQLDriverConnectW has returned, the application can crash. See microsoft/msphpsql#1594 for further details.
Closes #1469