Skip to content

Commit b76fd72

Browse files
mkschulzeclaude
andcommitted
fix(ci): correct artifact paths and CMake validate target
- Fix artifact path: JamWideJuce_artefacts (matches JUCE target name) - Guard validate CMake target with APPLE (TARGET_BUNDLE_DIR is macOS-only) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 5e32c72 commit b76fd72

2 files changed

Lines changed: 20 additions & 20 deletions

File tree

.github/workflows/juce-build.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ jobs:
3737
- name: Verify artifacts
3838
run: |
3939
echo "=== Build artifacts ==="
40-
ls -la "build/JamWide_artefacts/Release/VST3/JamWide.vst3/" || echo "VST3 not found"
41-
ls -la "build/JamWide_artefacts/Release/AU/JamWide.component/" || echo "AU not found"
42-
ls -la "build/JamWide_artefacts/Release/CLAP/JamWide.clap/" || echo "CLAP not found"
43-
ls -la "build/JamWide_artefacts/Release/Standalone/JamWide.app/" || echo "Standalone not found"
40+
ls -la "build/JamWideJuce_artefacts/Release/VST3/JamWide.vst3/" || echo "VST3 not found"
41+
ls -la "build/JamWideJuce_artefacts/Release/AU/JamWide.component/" || echo "AU not found"
42+
ls -la "build/JamWideJuce_artefacts/Release/CLAP/JamWide.clap/" || echo "CLAP not found"
43+
ls -la "build/JamWideJuce_artefacts/Release/Standalone/JamWide.app/" || echo "Standalone not found"
4444
4545
- name: Download pluginval
4646
run: |
@@ -56,7 +56,7 @@ jobs:
5656
--validate-in-process \
5757
--strictness-level 5 \
5858
--timeout-ms 120000 \
59-
--validate "build/JamWide_artefacts/Release/VST3/JamWide.vst3"
59+
--validate "build/JamWideJuce_artefacts/Release/VST3/JamWide.vst3"
6060
6161
- name: Validate AU
6262
continue-on-error: true
@@ -65,7 +65,7 @@ jobs:
6565
--validate-in-process \
6666
--strictness-level 5 \
6767
--timeout-ms 120000 \
68-
--validate "build/JamWide_artefacts/Release/AU/JamWide.component"
68+
--validate "build/JamWideJuce_artefacts/Release/AU/JamWide.component"
6969
7070
- name: Validate Standalone
7171
continue-on-error: true
@@ -74,17 +74,17 @@ jobs:
7474
--validate-in-process \
7575
--strictness-level 5 \
7676
--timeout-ms 120000 \
77-
--validate "build/JamWide_artefacts/Release/Standalone/JamWide.app"
77+
--validate "build/JamWideJuce_artefacts/Release/Standalone/JamWide.app"
7878
7979
- name: Upload macOS artifacts
8080
uses: actions/upload-artifact@v4
8181
with:
8282
name: JamWide-macOS
8383
path: |
84-
build/JamWide_artefacts/Release/VST3/
85-
build/JamWide_artefacts/Release/AU/
86-
build/JamWide_artefacts/Release/CLAP/
87-
build/JamWide_artefacts/Release/Standalone/
84+
build/JamWideJuce_artefacts/Release/VST3/
85+
build/JamWideJuce_artefacts/Release/AU/
86+
build/JamWideJuce_artefacts/Release/CLAP/
87+
build/JamWideJuce_artefacts/Release/Standalone/
8888
retention-days: 30
8989

9090
build-windows:
@@ -114,7 +114,7 @@ jobs:
114114
shell: pwsh
115115
run: |
116116
Write-Host "=== Build artifacts ==="
117-
Get-ChildItem -Path "build/JamWide_artefacts" -Recurse -Include "*.vst3","*.clap" -Directory | Select-Object FullName
117+
Get-ChildItem -Path "build/JamWideJuce_artefacts" -Recurse -Include "*.vst3","*.clap" -Directory | Select-Object FullName
118118
119119
- name: Download pluginval
120120
shell: pwsh
@@ -124,15 +124,15 @@ jobs:
124124
125125
- name: Validate VST3
126126
run: |
127-
pluginval\pluginval.exe --validate-in-process --strictness-level 5 --timeout-ms 120000 --validate "build\JamWide_artefacts\Release\VST3\JamWide.vst3"
127+
pluginval\pluginval.exe --validate-in-process --strictness-level 5 --timeout-ms 120000 --validate "build\JamWideJuce_artefacts\Release\VST3\JamWide.vst3"
128128
129129
- name: Upload Windows artifacts
130130
uses: actions/upload-artifact@v4
131131
with:
132132
name: JamWide-Windows
133133
path: |
134-
build/JamWide_artefacts/Release/VST3/
135-
build/JamWide_artefacts/Release/CLAP/
134+
build/JamWideJuce_artefacts/Release/VST3/
135+
build/JamWideJuce_artefacts/Release/CLAP/
136136
retention-days: 30
137137

138138
build-linux:
@@ -174,7 +174,7 @@ jobs:
174174
- name: Verify artifacts
175175
run: |
176176
echo "=== Build artifacts ==="
177-
find build/JamWide_artefacts -name "*.vst3" -o -name "*.clap" -o -name "*.so" | head -20
177+
find build/JamWideJuce_artefacts -name "*.vst3" -o -name "*.clap" -o -name "*.so" | head -20
178178
179179
- name: Download pluginval
180180
run: |
@@ -189,15 +189,15 @@ jobs:
189189
--validate-in-process \
190190
--strictness-level 5 \
191191
--timeout-ms 120000 \
192-
--validate "build/JamWide_artefacts/Release/VST3/JamWide.vst3"
192+
--validate "build/JamWideJuce_artefacts/Release/VST3/JamWide.vst3"
193193
194194
- name: Upload Linux artifacts
195195
uses: actions/upload-artifact@v4
196196
with:
197197
name: JamWide-Linux
198198
path: |
199-
build/JamWide_artefacts/Release/VST3/
200-
build/JamWide_artefacts/Release/CLAP/
199+
build/JamWideJuce_artefacts/Release/VST3/
200+
build/JamWideJuce_artefacts/Release/CLAP/
201201
retention-days: 30
202202

203203
release:

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ if(JAMWIDE_BUILD_JUCE)
330330
set(_pluginval_exe "${CMAKE_BINARY_DIR}/_pluginval/pluginval.exe")
331331
endif()
332332

333-
if(DEFINED _pluginval_url)
333+
if(APPLE AND DEFINED _pluginval_url)
334334
add_custom_target(validate
335335
COMMAND ${CMAKE_COMMAND}
336336
-D "PLUGINVAL_URL=${_pluginval_url}"

0 commit comments

Comments
 (0)