Tests for the neuralNetwork addData function.#102
Draft
lindapaiste wants to merge 1 commit intoml5js:mainfrom
Draft
Tests for the neuralNetwork addData function.#102lindapaiste wants to merge 1 commit intoml5js:mainfrom
addData function.#102lindapaiste wants to merge 1 commit intoml5js:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft because there is a some obnoxious issue with and
importstatement in the@tensorflow/tfjs-vispackage which causes Jest to crash while testing theNeuralNetwork/index.js file. I had to comment out a few lines regarding theNeuralNetworkViswhile working on the tests. Make I can make a jest mock for the file?There are a bunch of tests which fail at the moment that are being ignored with
.skip. These are things that I would like to improve in the neural network code eventually, such as throwing errors on logging warnings on incomplete data.