Skip to content

Llama 3.1 8B #813

Closed
suachong wants to merge 0 commit into
mlcommons:masterfrom
suachong:master
Closed

Llama 3.1 8B #813
suachong wants to merge 0 commit into
mlcommons:masterfrom
suachong:master

Conversation

@suachong

Copy link
Copy Markdown
Contributor

Continuing from the previous PR #799 with some cleanups.

@suachong suachong requested a review from a team as a code owner August 13, 2025 21:55
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
4 out of 5 committers have signed the MLCommons CLA.
@ZixianWangAMD
@mmarcinkiewicz
@hXl3s
@suachong
@zixian Wang
Zixian Wang seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Comment thread small_llm_pretraining/nemo/README.md Outdated

<!-- # 6. Other

#### Run model conversion

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop this section because there is no starting checkpoint for this benchmark. Submitters should not start from the HF checkpoint and instead they need to start from randomly initialized weights

# This is the checkpoint that we want to start with.
# Each checkpoint should be a folder containing two sub-folders: context and weights.
# And we need to pass this folder's path (the folder containing context and weights) here.
export MODEL_CKPT="/data/llama3_8b/model/Llama-3.1-8B_nemo"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no model ckpt, this should not be set.

export USE_CKPT=0
# Model: Whether we are resuming from a NeMo-formatted HuggingFace checkpoint (weights only).
# If set to 1, then checkpoint resuming code will not try to load the optimizer states.
export FROM_HF=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these flags since they are not relevant

# This is the checkpoint that we want to start with.
# Each checkpoint should be a folder containing two sub-folders: context and weights.
# And we need to pass this folder's path (the folder containing context and weights) here.
export MODEL_CKPT="/data/llama3_8b/model/Llama-3.1-8B_nemo"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this

export USE_CKPT=0
# Model: Whether we are resuming from a NeMo-formatted HuggingFace checkpoint (weights only).
# If set to 1, then checkpoint resuming code will not try to load the optimizer states.
export FROM_HF=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove HF flags

@@ -0,0 +1,10 @@
if __name__ == "__main__":

@ShriyaRishab ShriyaRishab Aug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not necessary

@@ -0,0 +1,23 @@
#!/bin/bash

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not necessary

@ShriyaRishab

Copy link
Copy Markdown
Contributor

There is an issue with the CLA again - this needs to be fixed #813 (comment)

@suachong suachong closed this Aug 15, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants