Skip to content

feat: add command polygon & ellipse and refine command spline & rect#198

Merged
mlightcad merged 1 commit intomainfrom
feat/cmd
Apr 9, 2026
Merged

feat: add command polygon & ellipse and refine command spline & rect#198
mlightcad merged 1 commit intomainfrom
feat/cmd

Conversation

@mlightcad
Copy link
Copy Markdown
Owner

Summary

This PR introduces ELLIPSE and POLYGON commands and significantly enhances interactive command input flows across drawing commands.

What Changed

  • Added new commands:
    • ELLIPSE (axis/center workflows, arc mode, rotation option, dynamic preview)
    • POLYGON (center mode with inscribed/circumscribed options, edge mode)
  • Upgraded existing commands:
    • CIRCLE: supports center/radius, center/diameter, 2P, and 3P flows
    • RECT: supports chamfer, fillet, width, elevation, thickness, area, dimensions, and rotation
    • LINE: supports chained input with Undo and Close
    • SPLINE: supports fit/CV methods, degree/knots options, undo/close, and improved preview stability
  • Input system updates:
    • Added base-angle support for angle prompts and rubber-band rendering
    • Improved keyboard handling during text input/IME composition
    • Added integer prompt support through editor APIs
  • Localization:
    • Added/updated EN and ZH command and jig strings for new workflows
  • Registration:
    • Registered ellipse and polygon commands in command manager/export index

Developer Notes

  • getKeywords now returns AcEdPromptResult (status + optional stringResult) instead of a raw string.
  • Cancel behavior for keyword prompts is now status-based rather than exception-driven.

Documentation

  • Added detailed TypeDoc comments to previously unannotated classes/members in input UI modules.

@mlightcad mlightcad self-assigned this Apr 9, 2026
@mlightcad mlightcad added the enhancement New feature or request label Apr 9, 2026
@mlightcad mlightcad merged commit da3546a into main Apr 9, 2026
2 checks passed
@mlightcad mlightcad deleted the feat/cmd branch April 10, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant