refactor!: migrate to TypeScript and ESM#65
Merged
Conversation
4 tasks
tpoisseau
force-pushed
the
64-export-types-of-arguments-and-returns-of-package-methods
branch
from
414d588 to
7b5f035
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 93.10% 96.29% +3.19%
==========================================
Files 5 5
Lines 145 351 +206
Branches 42 58 +16
==========================================
+ Hits 135 338 +203
- Misses 8 13 +5
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
targos
reviewed
Jun 11, 2025
targos
reviewed
Jun 11, 2025
targos
reviewed
Jun 11, 2025
targos
reviewed
Jun 11, 2025
targos
reviewed
Jun 11, 2025
targos
reviewed
Jun 11, 2025
Refs: #65 (comment) Refs: #65 (comment) Refs: #65 (comment) Refs: #65 (comment)
Member
|
You should also remove the old |
targos
reviewed
Jun 11, 2025
targos
reviewed
Jun 11, 2025
4 tasks
targos
reviewed
Jun 11, 2025
tpoisseau
force-pushed
the
64-export-types-of-arguments-and-returns-of-package-methods
branch
from
c13ca37 to
9904e0c
Compare
tpoisseau
force-pushed
the
64-export-types-of-arguments-and-returns-of-package-methods
branch
from
9904e0c to
52abf94
Compare
tpoisseau
added a commit
to cheminfo/generator-cheminfo
that referenced
this pull request
Jun 11, 2025
targos
approved these changes
Jun 11, 2025
tpoisseau
deleted the
64-export-types-of-arguments-and-returns-of-package-methods
branch
tpoisseau
added a commit
to cheminfo/generator-cheminfo
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #64 (comment)