Fix compilation warnings - #432
Merged
Merged
Conversation
Contributor
|
@rcurtin I didn't see anything pop-up on {RcppEnsmallen}'s test matrix: https://cran.r-project.org/web/checks/check_results_RcppEnsmallen.html Is this related to unreleased changes? (~December '24 last CRAN release). |
Member
Author
|
Probably? These are just warnings I saw compiling locally; not sure when they snuck in. Either way they are easy enough to fix and this probably pre-empts CRAN-related frustrations. |
conradsnicta
approved these changes
Sep 3, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some warnings I see when I compile ensmallen locally. I also fixed the style in the MAF functions (or at least took a quick pass at it).