Refactor calculatedObjectives in NSGA2 optimizer - #434
Merged
Conversation
Signed-off-by: yexiaochuan <tap91624@gmail.com>
Contributor
rcurtin
reviewed
Sep 15, 2025
rcurtin
left a comment
Member
There was a problem hiding this comment.
Hey @XueSongTap, thank you for the contribution! I have some comments. If you can handle them we can get this merged.
Member
|
I handled all the comments and merged in the master branch. If the tests pass I think this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #433
Refactor NSGA2 calculatedObjectives from std::vectorarma::Col to arma::Cube
Changes
Replaced
std::vector<arma::Col<ElemType>>with anarma::Cube<ElemType>forcalculatedObjectives.(numObjectives x 1 x populationSize)Updated all related methods (
EvaluateObjectives,FastNonDominatedSort,Dominates,CrowdingDistanceAssignment, etc.) to work with the cube representation.Compatibility
calculatedObjectivesis now a cube instead of a vector of columns.