Skip to content

Remove deprecated functionality for ensmallen 3.x release. - #435

Merged
rcurtin merged 7 commits into
mlpack:masterfrom
rcurtin:deprecated-cleanup
Sep 16, 2025
Merged

Remove deprecated functionality for ensmallen 3.x release.#435
rcurtin merged 7 commits into
mlpack:masterfrom
rcurtin:deprecated-cleanup

Conversation

@rcurtin

@rcurtin rcurtin commented Sep 2, 2025

Copy link
Copy Markdown
Member

This removes the ParetoFront() and ParetoSet() functions from the multi-objective optimizers, since we are about to do a major version bump of ensmallen. There are also a couple other deprecated things I found and removed.

@conradsnicta

Copy link
Copy Markdown
Contributor

@rcurtin Recommend making a note in HISTORY.md specifying what was removed and what functionality should be used instead. Many people tend to compile stuff while disregarding the deprecation warning messages. Only when something breaks they get interested and start looking at what happened. Having an explanation in HISTORY.md would help them fix their code.

@coatless

Copy link
Copy Markdown
Contributor

@rcurtin to follow-up on @conradsnicta's point; maybe include a code snippet of moving from v2.y.z to v3.y.z line showing old and, then, new code instead of the documentation redirect. Esp if v3.y.z has coot support. I think that probably will need a concise here's GPUs and, then, a longer version.

@rcurtin

rcurtin commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

Thanks, agreed. I just pushed a better message with a more coherent description of how to convert code. It's a little more tedious to write all that out, but better than unhappy users who get frustrated and find a different library. (Although to my knowledge there are simply zero other choices in C++ for something like what ensmallen does!)

@rcurtin
rcurtin merged commit 8151354 into mlpack:master Sep 16, 2025
6 checks passed
@rcurtin
rcurtin deleted the deprecated-cleanup branch September 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants