Merge Bandicoot tests with other tests - #438
Merged
Merged
Conversation
conradsnicta
approved these changes
Sep 16, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
zoq
approved these changes
Sep 17, 2025
Member
Author
|
67m for OpenCL and 48m for CUDA, looks good to me. I changed around a few more tests but all the same optimizers are tested with GPUs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the tests already are of the form
so they work over all ensmallen test types. We can do the same thing with the Bandicoot tests, so I modified the definition of
ENS_ALL_TEST_TYPESand merged all of the Bandicoot-specific test types accordingly.No actual tests should really be changing here, it is just a cleanup.