Deprecate the Lambda() and Sigma() functions for AugLagrangian - #439
Merged
Conversation
…an issue with dealgood.)
zoq
approved these changes
Sep 23, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the review process for #352, we identified that the
AugLagrangianclass, like the multi-objective optimizers, had a template parameter that it shouldn't and stored state that was really a result of the optimization and should be something returned byOptimize(). So, before this PR, if you wanted to get the Lagrange multipliers and penalty parameter after optimization, you would do:arma::vec lambda; double sigma; opt.Optimize(function, coordinates); lambda = opt.Lambda(); sigma = opt.Sigma();However, much like the pareto front and population for multi-objective optimizers, this is really something that should be done more like this:
arma::vec lambda; double sigma; opt.Optimize(function, coordinates, lambda, sigma);This PR makes that change (although there was some extra work necessary to disambiguate different overloads). Documentation is updated too.