You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This reverts commit db5cef9. The reason is that when we merge releases (as listed in the auto-generated description) they need to be rebased to produce two commits: the first is the one that gets tagged for the release, the second is the new HEAD with the new empty HISTORY.md block.
@rcurtin Seems to be a rather convoluted release process :)
(The ensmallen webpage and the Releases section also need to be updated. I started a PR for this on the ensmallen.org repo, then realised that there was no new release .tar.gz yet)
(The ensmallen webpage and the Releases section also need to be updated. I started a PR for this on the ensmallen.org repo, then realised that there was no new release .tar.gz yet)
Yes, because the entire purpose of the 'convoluted' release process was to automate it. The scripts for this automation are all in scripts/, including the post-release website update script. The intention is to run that inside of a Github action or bot equivalent so that releases really are just "run a script, it does everything else". But, for this to work, it depends on the release merge being a rebase instead of a squash (or really anything other than a squash will do), otherwise you have no commit that you can tag to be the new release. I'll try again once we merge this revert and then I will have a commit to use as the tag and all the scripts will work fine---and the webpage will be automatically updated via scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit db5cef9. The reason is that when we merge releases (as listed in the auto-generated description) they need to be rebased to produce two commits: the first is the one that gets tagged for the release, the second is the new
HEADwith the new emptyHISTORY.mdblock.