Fix ParallelSGD test step sizes and enable OpenMP for tests when found - #454
Merged
Merged
Conversation
| PROPERTY INTERFACE_LINK_LIBRARIES ${OpenMP_CXX_FLAGS} Threads::Threads) | ||
| endif() | ||
|
|
||
| add_definitions(-DENS_USE_OPENMP) |
There was a problem hiding this comment.
Should it be target_compile_definition instead?
Member
Author
There was a problem hiding this comment.
Thanks---my CMake is often pretty primitive. Fixed in fd4362d.
zoq
approved these changes
Apr 17, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #452. When the tests were refactored for Bandicoot over last summer, one thing that got overlooked was the ParallelSGD tests, since they require OpenMP to be enabled to run... and our CMake configuration did not actually do that even when it found OpenMP! So, two fixes:
Actually enable OpenMP if we find it...
and update the step sizes for each of the ParallelSGD tests since they were way too large and caused divergence.
I ran the tests for 1000 iterations locally with no problems.