Allow multiple trials for Lookahead logistic regression test - #456
Merged
Conversation
…st (it fails ~1 out of 1k times).
eddelbuettel
approved these changes
May 1, 2026
eddelbuettel
left a comment
eddelbuettel
left a comment
Contributor
There was a problem hiding this comment.
Nice trick to fall victim to an unlucky (and rare) RNG draw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw in another PR that this test randomly failed and was a little bit disappointed because of the time I spent last summer tuning all the test suites so they had no test failures in 1000 runs. So, I ran the test locally another 1000 times and saw one failure... an easy fix is just to allow multiple trials for the logistic regression test, so I did that, and in ~4k trials I saw no failures.