Skip to content

Initialize the gradient constraint matrix instead of expecting the user to - #458

Merged
rcurtin merged 1 commit into
mlpack:masterfrom
rcurtin:fix-auglagrangian-gradient-constraint-initialization
Jul 25, 2026
Merged

Initialize the gradient constraint matrix instead of expecting the user to#458
rcurtin merged 1 commit into
mlpack:masterfrom
rcurtin:fix-auglagrangian-gradient-constraint-initialization

Conversation

@rcurtin

@rcurtin rcurtin commented Jul 10, 2026

Copy link
Copy Markdown
Member

This fixes #457. The bug report there is that AugLagrangian is not setting the size of the gradient matrix before calling the function's GradientConstraint() method.

It's a pretty simple fix, and it's now tested because I modified the AugLagrangian test functions to ensure that some of them expect the gradient size to already be set.

@eddelbuettel eddelbuettel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin
rcurtin merged commit 3967e5b into mlpack:master Jul 25, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Augmented Lagrangian optimiser seems to fail?

2 participants