feat: try to guess file type rather than trust file ext - #77
Open
McPatate wants to merge 1 commit into
Open
Conversation
Signed-off-by: Luc Georges <luc.sydney.georges@gmail.com>
Owner
|
AI-generated PR description for future reference: MotivationThe hub-side scanner sees a steady trickle of errors from files whose extension What this changesDispatch on content first, extension second.
Two crashes fixed along the way.
TestingFour new tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we've been having some amount of errors on the hub scanner side, which this would help mitigate. Rather than having to reimplement in our codebase, imo it makes sense to have this logic here!
Curious to hear your feedback on this. AI-generated with some reviewing/clean up.