fix: guard WorkingDirectory.resolve(String) against absolute paths#3180
Merged
fix: guard WorkingDirectory.resolve(String) against absolute paths#3180
Conversation
The resolve(String) overload did not check whether the input was already absolute, so File(baseDir, absolutePath) stripped the leading separator and concatenated, producing duplicated paths like /Users/foo/mcp-sandbox/Users/foo/mcp-sandbox/flow.yaml when the MCP run_flow_files tool was called with an absolute path on first run. Delegate to the resolve(File) overload so the absolute-path guard lives in exactly one place. Fixes MA-4005 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Leland-Takamine
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkingDirectory.resolve(path: String)did not checkisAbsolute, soFile(baseDir, absolutePath)stripped the leading separator and concatenated, producing duplicated paths like/Users/foo/mcp-sandbox/Users/foo/mcp-sandbox/flow.yaml.resolve(file: File)overload already guards correctly; theStringoverload now delegates to it so the absolute-path rule lives in one place.RunFlowFilesTool.kt:70, and its tool description explicitly encourages absolute paths, so this path is well-exercised in practice.🤖 Generated with Claude Code