fix(manager): persist manager language across logout/login#16928
Open
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Open
fix(manager): persist manager language across logout/login#16928Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Conversation
Store manager language in cookie (modx_manager_language) so it survives session end. Read cookie on login, set on language change and login. Redirect to ?manager_language=XX after logout for immediate restore. Fixes modxcms#16072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Store manager language in cookie
modx_manager_languageso it survives session end. Read cookie on login, set on language change and login. Redirect to?manager_language=XXafter logout for immediate restore.Changes:
login.class.php: read cookie, validate against lexicon, set session and cookielanguage.class.php: set cookie when user switches languagelogout.class.php: addmanager_languageto redirect URLmodx.js: on logout success, read cookie and redirect withmanager_languagemodX.php: newsetManagerLanguageCookie()methodWhy is it needed?
Manager language resets to default after logout because it was only stored in
$_SESSION. Session is destroyed on logout, so the preference was lost.How to test
Related issue(s)/PR(s)
Resolves #16072