Fix TARGET=clang: avoid redefining mode_t (POSIX type)#15
Open
SteveC wants to merge 2 commits into
Open
Conversation
Remove typedef of cp_csg2_bool_mode_t as mode_t, which conflicts with the system mode_t on macOS and other platforms. Use cp_csg2_bool_mode_t directly in flatten_eager(). Made-with: Cursor
Two causes: 1. Deep CSG tree recursion in cp_csg2_tree_add_layer - replaced with iterative traversal using explicit worklist stack. 2. System qsort recursion in cq_slice_add_face - replaced with iterative quicksort using explicit stack (O(log n) depth). Also fix internal.c: use (size_t)-1 for clang -Wimplicit-int-conversion. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove typedef of cp_csg2_bool_mode_t as mode_t, which conflicts with the system mode_t on macOS and other platforms. Use cp_csg2_bool_mode_t directly in flatten_eager().
... so it compiles on macos.