[DRAFT] Remove sms from android store #1889#1890
Open
sultanahamer wants to merge 6 commits intomoezbhatti:masterfrom
Open
[DRAFT] Remove sms from android store #1889#1890sultanahamer wants to merge 6 commits intomoezbhatti:masterfrom
sultanahamer wants to merge 6 commits intomoezbhatti:masterfrom
Conversation
sultanahamer
commented
Aug 21, 2022
| applicationIdSuffix '.debug' | ||
| debuggable true | ||
| minifyEnabled false | ||
| } |
Author
There was a problem hiding this comment.
This code adds a test version of same app with name DQKSMS so that I can test on phone along with prod still installed.
We can get rid of this if you feel its not required after testing
sultanahamer
commented
Aug 21, 2022
| <application | ||
| android:name=".common.QKApplication" | ||
| android:allowBackup="true" | ||
| android:allowBackup="false" |
Author
There was a problem hiding this comment.
This one syncs the database/preferences to Google cloud which won't make sense in most of the app instances. We can remove this if you think otherwise.
sultanahamer
commented
Aug 21, 2022
| <application | ||
| android:allowBackup="false" | ||
| android:icon="@mipmap/ic_launcher" | ||
| android:label="DQKSMS" |
Author
There was a problem hiding this comment.
This file is needed to give the name DQKSMS for debug app.
This is more like extends default manifest and has only overrides like app name.
Also removed sync from happening automatically when default messaging app changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1889
Used this app for a day and realized the following
Will update this as I face more things
Code snippet for problem 1