feat(skill): add PR review skill (#88)

core/src/agent/context.rs

@@ -331,3 +331,46 @@ Read the skill's SKILL.md file using the `read_file` tool to learn how to use it
         &self.skills
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::config::default_config;
+    use tempfile::tempdir;
+
+    #[tokio::test]
+    async fn test_skills_summary_includes_pr_review() {
+        let temp = tempdir().expect("tempdir");
+        let mut config = default_config();
+        config.agents.defaults.workspace = temp.path().display().to_string();
+
+        let context = ContextBuilder::new(&config);
+        let prompt = context
+            .build_system_prompt(None)
+            .await
+            .expect("system prompt");
+
+        assert!(
+            prompt.contains("pr-review"),
+            "prompt did not include pr-review skill summary"
+        );
+    }
+
+    #[tokio::test]
+    async fn test_requested_pr_review_skill_is_loaded() {
+        let temp = tempdir().expect("tempdir");
+        let mut config = default_config();
+        config.agents.defaults.workspace = temp.path().display().to_string();
+
+        let context = ContextBuilder::new(&config);
+        let requested = vec!["pr-review".to_string()];
+        let prompt = context
+            .build_system_prompt(Some(&requested))
+            .await
+            .expect("system prompt");
+
+        assert!(prompt.contains("# Requested Skills"));
+        assert!(prompt.contains("# PR Review Skill"));
+        assert!(prompt.contains("PR Template Compliance"));
+    }
+}

core/src/session/mod.rs

@@ -93,7 +93,8 @@ impl SessionManager {
 
     /// Get an existing session or create a new one (delegates to mofa)
     pub async fn get_or_create(&self, key: impl Into<String>) -> Session {
-        self.inner.get_or_create(&key.into()).await
+        let key = key.into();
+        self.inner.get_or_create(&storage_key(&key)).await
     }
 
     /// Load a session from disk
@@ -127,7 +128,7 @@ impl SessionManager {
     /// Delete a session (delegates to mofa)
     pub async fn delete(&self, key: &str) -> Result<bool> {
         self.inner
-            .delete(key)
+            .delete(&storage_key(key))
             .await
             .map_err(|e| crate::error::SessionError::LoadFailed(e.to_string()).into())
     }
@@ -177,8 +178,7 @@ impl SessionManager {
 
     /// Get the file path for a session
     fn get_session_path(&self, key: &str) -> PathBuf {
-        let safe_key = safe_filename(&key.replace(':', "_"));
-        self.sessions_dir.join(format!("{}.jsonl", safe_key))
+        self.sessions_dir.join(format!("{}.jsonl", storage_key(key)))
     }
 
     /// Get the inner mofa SessionManager (for advanced usage)
@@ -200,6 +200,10 @@ fn safe_filename(name: &str) -> String {
         .collect()
 }
 
+fn storage_key(key: &str) -> String {
+    safe_filename(&key.replace(':', "_"))
+}
+
 // ============================================================================
 // Conversion utilities between mofaclaw Message and mofa SessionMessage
 // ============================================================================
@@ -305,6 +309,12 @@ mod tests {
         assert_eq!(safe_filename("test/file@name"), "test_file_name");
     }
 
+    #[test]
+    fn test_storage_key_replaces_windows_unsafe_separators() {
+        assert_eq!(storage_key("cli:default"), "cli_default");
+        assert_eq!(storage_key("discord:general/chat"), "discord_general_chat");
+    }
+
     #[test]
     fn test_message_conversion() {
         // Test Message -> SessionMessage
@@ -354,13 +364,13 @@ mod tests {
         let manager = SessionManager::with_sessions_dir(temp_dir.path().to_path_buf());
 
         let session = manager.get_or_create("test:session").await;
-        assert_eq!(session.key, "test:session");
+        assert_eq!(session.key, "test_session");
 
         manager.save(&session).await.unwrap();
 
         // Reload
         let loaded = manager.get_or_create("test:session").await;
-        assert_eq!(loaded.key, "test:session");
+        assert_eq!(loaded.key, "test_session");
     }
 
     #[tokio::test]

skills/README.md

@@ -6,6 +6,7 @@ This directory contains the builtin skills for mofaclaw. These skills are automa
 
 - **weather** - Get current weather and forecasts using wttr.in (no API key required)
 - **github** - Interact with GitHub using the `gh` CLI
+- **pr-review** - Review pull requests with structured checks for scope, security, tests, CI, and reviewer comments
 - **summarize** - Summarize or extract text/transcripts from URLs, podcasts, and local files
 - **tmux** - Remote-control tmux sessions for interactive CLIs
 - **skill-creator** - Meta-skill for creating new skills