Skip to content

assign2: add assignment 2 solution#29

Open
sameem420 wants to merge 1 commit intomohammadrajabraza:mainfrom
sameem420:main
Open

assign2: add assignment 2 solution#29
sameem420 wants to merge 1 commit intomohammadrajabraza:mainfrom
sameem420:main

Conversation

@sameem420
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@mohammadrajabraza mohammadrajabraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! However you need to update commit message like git commit -m "assign1: add assignment 1 solution" as advised in the issue

@sameem420 sameem420 changed the title Assignment 2 solution added assign2: add assignment 2 solution Sep 23, 2021
@sameem420
Copy link
Copy Markdown
Author

Good work! However you need to update commit message like git commit -m "assign1: add assignment 1 solution" as advised in the issue

Sir If I did now, I have to added files again. I will keep in mind and do it the same way next time.Thanks

@mohammadrajabraza mohammadrajabraza added the hacktoberfest-accepted Fulfill the acceptance criteria label Oct 27, 2021
@mohammadrajabraza
Copy link
Copy Markdown
Owner

No, you won't have to add files. Just reset --soft this commit and commit again with the new commit message. these changes are required to merge your changes in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Fulfill the acceptance criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants