Assignment 4: Static Website Using Actix-Web #58
Open
YAHYA-YOUNAS wants to merge 2 commits intomohammadrajabraza:mainfrom
Open
Assignment 4: Static Website Using Actix-Web #58YAHYA-YOUNAS wants to merge 2 commits intomohammadrajabraza:mainfrom
YAHYA-YOUNAS wants to merge 2 commits intomohammadrajabraza:mainfrom
Conversation
Owner
mohammadrajabraza
left a comment
mohammadrajabraza
left a comment
There was a problem hiding this comment.
Good work. But you could have merged 2 commits into 1.
Author
|
Yes, sir, I developed a static website but I didn't know about the routing. Therefore, images and CSS were not loaded. Then I make changes and push again. |
Owner
|
Okay, but that can be done by resetting your existing commit, and after adding/editing your work, you can create a new commit and push forcefully. This can be repeated multiple times to add additional changes. |
Owner
mohammadrajabraza
left a comment
mohammadrajabraza
left a comment
There was a problem hiding this comment.
Your solution is up to the mark but requested changes don't let me merge your PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a complete static website with stylesheets and images using dynamic routes in actix web server.