Open
Conversation
Member
|
I can take a look at this later, but from what I can tell this would still leave #201 as an issue. Not sure if you'd want to figure out a solution for that here, or if you'd rather leave that alone right now. |
Member
Author
|
I've specifically tested that case and it should work (though only with my second commit) |
Contributor
|
Missed this: discord.js support for pomelo was added in 14.12.0 (currently using 14.2.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Display new user handles as
@violine1101and old ones asvioline1101#8993everywhere.This also should fix the issue where messages could not be deleted if you had a new user handle.
Approach
Add a helper function in
DiscordUtilto decide how to print the name. Also added two more helper function for consistent setting of embed footers and authors.Future work
We'll probably need to rework this with the next discord.js update anyway, I presume (though I haven't checked their progress on the matter)