Reject unofficial bug tracker links#327
Open
BugTracker-BH wants to merge 2 commits intomojira:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rejects requests that contain links to unofficial bug tracker mirrors (such as mojira-viewer.jacobsjo.eu, mojira.dev) instead of the official bugs.mojang.com. This prevents users from referencing third-party mirrors.
Approach
Added a static method
containsUnofficialBugTrackerLink()inRequestsUtilthat uses a regex to detect any third-party URL. InRequestEventHandler, this check is run before processing a request, if an unofficial link is detected, the bot reacts with the invalid ticket emoji and sends a warning message directing the user to bugs.mojang.com, then returns early.Future work
N/A