Refactoring: ArtifactFactory and ArtifactVersionService#1218
Merged
andrzejj0 merged 1 commit intomojohaus:masterfrom Mar 4, 2025
Merged
Refactoring: ArtifactFactory and ArtifactVersionService#1218andrzejj0 merged 1 commit intomojohaus:masterfrom
andrzejj0 merged 1 commit intomojohaus:masterfrom
Conversation
slawekjaranowski
approved these changes
Mar 4, 2025
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
Some a nit comments - but look ok.
versions-common/src/test/java/org/codehaus/mojo/versions/api/DefaultVersionsHelperTest.java
Show resolved
Hide resolved
...s-maven-plugin/src/test/java/org/codehaus/mojo/versions/DisplayExtensionUpdatesMojoTest.java
Show resolved
Hide resolved
versions-maven-plugin/src/test/java/org/codehaus/mojo/versions/LockSnapshotsMojoTest.java
Outdated
Show resolved
Hide resolved
...ons-maven-plugin/src/test/java/org/codehaus/mojo/versions/UseLatestVersionsMojoTestBase.java
Outdated
Show resolved
Hide resolved
versions-maven-plugin/src/test/java/org/codehaus/mojo/versions/UseReleasesMojoTest.java
Outdated
Show resolved
Hide resolved
andrzejj0
force-pushed
the
artifact-factory
branch
from
61d974a to
24534c1
Compare
slawekjaranowski
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stage of the refactoring job mentioned in #1212