Removed numeric and mercury comparators, further refactoring#1222
Merged
andrzejj0 merged 2 commits intomojohaus:masterfrom Mar 9, 2025
Merged
Removed numeric and mercury comparators, further refactoring#1222andrzejj0 merged 2 commits intomojohaus:masterfrom
andrzejj0 merged 2 commits intomojohaus:masterfrom
Conversation
slawekjaranowski
approved these changes
Mar 9, 2025
Member
slawekjaranowski
left a comment
There was a problem hiding this comment.
We also should preserve old schema at site:
https://www.mojohaus.org/versions/versions-model/xsd/index.html
can be done at separate PR
Contributor
Author
|
@slawekjaranowski would that be ok? |
Member
try to generate site locally ... we need an old link to works - https://www.mojohaus.org/versions/versions-model/xsd/rule-2.1.0.xsd |
Contributor
Author
|
I will do the proper site in another PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third stage of the refactoring: removed the Numeric and Mercury comparators, some further refactoring in DefaultVersionsHelper.
Because we're removing comparators, a new version of rules.xsd is necessary and it's a breaking change.