Truncate milliseconds shorthand in ISO#1412
Open
EzeGmnz wants to merge 3 commits intomoment:masterfrom
Open
Conversation
|
This was referenced Apr 2, 2023
|
Hi, any news about this? this would be very helpful. Thanks! |
|
I see this is still not merged while this is certainly useful. For the time being, this can be work arounded as follows: |
|
What is the status of this issue? |
Contributor
This functionality is added by #1670 which will be released on the next release of luxon (soon, I think?). It adds an optional This PR can be closed as duplicate. |
|
When is the next release of luxon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new parameter to DateTime#toISO and toISOTime called truncateMilliseconds which will remove the milliseconds from the format, irrespective of their value.
Added tests