Add simple polyfill for Intl.ListFormat#1585
Open
thatsmydoing wants to merge 1 commit intomoment:masterfrom
Open
Add simple polyfill for Intl.ListFormat#1585thatsmydoing wants to merge 1 commit intomoment:masterfrom
thatsmydoing wants to merge 1 commit intomoment:masterfrom
Conversation
diesieben07
requested changes
Jun 4, 2024
Collaborator
diesieben07
left a comment
diesieben07
left a comment
There was a problem hiding this comment.
Please add a test for this.
You can see how the other polyfill tests work, for example test/info/localeWeek.test.js.
thatsmydoing
force-pushed
the
list-polyfill
branch
from
6edaf37 to
09a9314
Compare
thatsmydoing
force-pushed
the
list-polyfill
branch
from
09a9314 to
23a368a
Compare
thatsmydoing
commented
Jun 6, 2024
Contributor
Author
thatsmydoing
left a comment
thatsmydoing
left a comment
There was a problem hiding this comment.
I've added the tests
|
|
||
| Helpers.withoutLF("Duration#toHuman falls back to commas", () => { | ||
| expect(dur().reconfigure({ locale: "ja" }).toHuman()).toEqual( | ||
| "1 年, 2 か月, 1 週間, 3 日, 4 時間, 5 分, 6 秒, 7 ミリ秒" |
Contributor
Author
There was a problem hiding this comment.
I picked Japanese since it uses a different comma style
There was a problem hiding this comment.
@diesieben07 Hey sorry for the tag, just checking if u had a look at this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1189