Open
Conversation
Collaborator
|
While this is a valid bugfix, I am reluctant to merge this in and release it as a minor update, because it is technically a breaking change. Normally that would be fine for a bug fix, but I can imagine many people intentionally or unintentionally relying on this behavior. Maybe we should add a What do you think, @icambron? |
|
@diesieben07 are you suggesting something like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue: #1625
Description of the Bug
The
DateTime.fromFormat()function incorrectly validates certain 24-hour formats as valid when they should be considered invalid.When using the 12-hour (h) format in the format parameter, the function does not properly invalidate times where the hour exceeds 12.
Actual vs Expected Behavior
Actual:
isValidreturns true forDateTime.fromFormat('18:30 AM', 'h:mm a').Expected:
isValidshouldn't be true because 18 is not a valid hour for the 12-hour (h) format.Fix Description
This PR addresses the issue by ensuring that when the 12-hour (h) format is used in the format parameter, any hour value greater than 12 is considered
invalid, and isValid will throw error.