feat(List): new component#3240
Merged
Merged
Conversation
Contributor
|
📦 Bundle Size Analysis ✅ No bundle size changes detected. Unchanged Components
📊 Summary:
|
Accept master changes for BaseList and BaseItem components which were already incorporated from the base-list branch that was merged to master.
Contributor
⚡ Performance Report
📈 Performance Changes
📋 Unchanged Stories (182)These stories showed no significant performance changes. ℹ️ About this report📏 Thresholds:
Legend: |
Contributor
PR Reviewer Guide 🔍(Review updated until commit afc4476)Here are some key observations to aid the review process:
|
talkor
approved these changes
Feb 8, 2026
| tooltipProps, | ||
| onClick, | ||
| onHover, | ||
| "data-testid": dataTestId |
Contributor
Author
There was a problem hiding this comment.
We usually only add it to the top level component not the individual items, no?
qodo-free-for-open-source-projects
Bot
added
Review effort 3/5
and removed
Review effort 4/5
labels
qodo-free-for-open-source-projects
Bot
added
Review effort 4/5
and removed
Review effort 3/5
labels
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
https://monday.monday.com/boards/3532714909/views/80492480/pulses/10829223605
PR Type
Enhancement
Description
Introduce new List component in
/nextfolder with improved API and accessibilityAdd ListItem and ListTitle sub-components with data-driven props interface
Implement comprehensive keyboard navigation and focus management
Add extensive test coverage and documentation with multiple story variants
Migrate legacy List documentation to
/legacyfolder with deprecation noticesDiagram Walkthrough
File Walkthrough
14 files
New List component implementationList component type definitionsList component stylingNew ListItem component implementationListItem component type definitionsListItem component exportsNew ListTitle component implementationListTitle component type definitionsListTitle component styling with sticky supportListTitle component exportsList package exports and re-exportsExport List from next componentsAdd hover state and focus styling to BaseItemAdd LIST_TITLE test ID and vibe ID constants1 files
Comprehensive List component test suite1 files
Fix highlighted prop handling with undefined check9 files
Update List documentation for new componentRewrite List stories for new component APIUpdate ListItem documentation for new APIRewrite ListItem stories for new component APIArchive legacy List documentation with deprecation noticeArchive legacy List storiesArchive legacy List story helpersArchive legacy ListItem documentation with deprecation noticeArchive legacy ListItem stories