Get phpcs to run without error - #153
Conversation
itismadness
changed the title
There was a problem hiding this comment.
It probably is a better idea not to exclude the phpcs rules and fix those separately.
There was a problem hiding this comment.
Depends on what you want out of phpcs until the rule violations are fixed. Do you want the output of phpcs to continue to be largely ignored until all violations are fixed, or do you want it to be listened to for the rules that are working fine atm, while slowly fixing the excluded rules over subsequent PRs. My preference would be for the former.
|
This is a good idea, given the current codebase. I think we should open an issue, something like ~"TODO: fix PHPCS exclusions". Then hopefully we'll see PRs for each item individually.
All those seem like things that should be fixed (sometimes I don't care much for some of the rules). |
3 participants
Most of the changes here are a result of running
vendor/bin/phpcbf, and then excluding all rules that still fail as they need to be manually fixed and better to do that in more PRs to keep this easy to review/merge. When reviewing, would encourage to click the option to ignore whitespace changes.